https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15924
src/objects.cc:15924: MaybeObject*
OrderedHashTable<entrysize>::EnsureGrowable() {
On 2014/04/02 12:09:37, Michael Starzinger wrote:
Is there a particular reason why this implementation is unhandlified
and the
sub-classes contain handle-wrappers? If not, I would vote for making
this
implementation be handle-based. IIUC, this would alleviate the need to
even
declare them explicitly.
Admittedly, doing that straight-forward would make the return type be
Handle<OrderedHashTable> instead of the concrete sub-class. But one
idea
(courtesy of Andreas) would be to add a second template parameter (in
addition
to "entrysize") to declare to concrete type.
More concretely, something like
template<class Derived, int entrysize> class OrderHashTable {
// ..., e.g.:
Handle<Derived> Rehash(Handle<Derived>);
};
class OrderedHashSet: OrderedHashTable<OrderedHashSet, 1> { ... };
should work (perhaps with some extra tweaks).
https://codereview.chromium.org/220293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
