https://codereview.chromium.org/220293002/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/80001/src/objects.cc#newcode15900
src/objects.cc:15900: // capacity must be a factor of two
On 2014/04/04 09:38:13, Michael Starzinger wrote:
nit: Comment says "factor", code says "power". Also please capitalize
and
punctuate comment.
Done and explained why. In a follow-up I'll probably just add a
"capacity" field.
https://codereview.chromium.org/220293002/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/220293002/diff/80001/src/objects.h#newcode4294
src/objects.h:4294: static OrderedHashTable* cast(Object* obj) {
On 2014/04/04 09:38:13, Michael Starzinger wrote:
nit: Since this can be considered an abstract class and the two
concrete
sub-classes both have their own casting method, should we even have
this casting
method? If it is actually used/needed anywhere I am fine with it of
course.
Removed, this was previously used but no longer.
https://codereview.chromium.org/220293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
