LGTM (👀👍). I like it. Just a couple of nits. Only one real suggestion about
the
ChildIteratorStart function.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251
src/objects.cc:7251: explicit IntrusiveMapTransitionIterator(
nit: Doesn't need to be "explicit" any longer.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7260
src/objects.cc:7260: *IteratorField() = Smi::FromInt(-1);
Can we ASSERT(*IteratorField() == constructor_) here before storing the
smi?
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7272
src/objects.cc:7272: int index = (value * -1) - 1;
nit: Would "-value - 1" be easier to read?
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7295
src/objects.cc:7295: // of map while it is running. Positive values in
the constructor field
nit: s/of map/of the map/
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7300
src/objects.cc:7300: explicit IntrusivePrototypeTransitionIterator(
nit: Doesn't need to be "explicit" any longer.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7306
src/objects.cc:7306: *IteratorField() = Smi::FromInt(0);
Can we ASSERT(*IteratorField() == constructor_) here before storing the
smi?
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7392
src/objects.cc:7392: void ChildIteratorStart(Object* constructor) {
It might make it more uniform to to get rid of the explicit
ChildIteratorStart() and do implicit StartOfNotStarted() within
ChildIteratorNext() for both of the sub-iterators. WDYT?
https://codereview.chromium.org/223533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
