https://codereview.chromium.org/223533002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251
src/objects.cc:7251: explicit IntrusiveMapTransitionIterator(
On 2014/04/03 13:07:37, Michael Starzinger wrote:
nit: Doesn't need to be "explicit" any longer.
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7260
src/objects.cc:7260: *IteratorField() = Smi::FromInt(-1);
On 2014/04/03 13:07:37, Michael Starzinger wrote:
Can we ASSERT(*IteratorField() == constructor_) here before storing
the smi?
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7272
src/objects.cc:7272: int index = (value * -1) - 1;
On 2014/04/03 13:07:37, Michael Starzinger wrote:
nit: Would "-value - 1" be easier to read?
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7295
src/objects.cc:7295: // of map while it is running. Positive values in
the constructor field
On 2014/04/03 13:07:37, Michael Starzinger wrote:
nit: s/of map/of the map/
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7300
src/objects.cc:7300: explicit IntrusivePrototypeTransitionIterator(
On 2014/04/03 13:07:37, Michael Starzinger wrote:
nit: Doesn't need to be "explicit" any longer.
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7306
src/objects.cc:7306: *IteratorField() = Smi::FromInt(0);
On 2014/04/03 13:07:37, Michael Starzinger wrote:
Can we ASSERT(*IteratorField() == constructor_) here before storing
the smi?
Done.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7392
src/objects.cc:7392: void ChildIteratorStart(Object* constructor) {
On 2014/04/03 13:07:37, Michael Starzinger wrote:
It might make it more uniform to to get rid of the explicit
ChildIteratorStart()
and do implicit StartOfNotStarted() within ChildIteratorNext() for
both of the
sub-iterators. WDYT?
Done. That is an awesome comment, thanks! Note that it is not completely
symmetric, since I cannot ASSERT(!(*IteratorField())->IsSmi() ||
IsIterating()); in the IntrusivePrototypeTransitionIterator.
https://codereview.chromium.org/223533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
