https://codereview.chromium.org/188783003/diff/120001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc#newcode458
src/ic.cc:458:
maps.at(i)->AddDependentCode(DependentCode::kWeaklyEmbeddedGroup, stub);
On 2014/04/03 15:18:36, Toon Verwaest wrote:
This means that all maps have 2 pointers to monomorphic ICs, once in
the code
cache, and once in the dependency list. Can we unify?
Can we avoid clearing the code cache now that those pointers are weak?
As discussed offline, we can probably do that if linear search time is
ok.
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc#newcode472
src/ic.cc:472: BaseLoadStoreStubCompiler::MissBuiltin(stub->kind()));
On 2014/04/03 15:18:36, Toon Verwaest wrote:
4-space indent
Done.
https://codereview.chromium.org/188783003/diff/120001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/188783003/diff/120001/src/mark-compact.cc#newcode2723
src/mark-compact.cc:2723: if (code->is_weak_stub()) {
On 2014/04/03 15:18:36, Toon Verwaest wrote:
Also IsMarked(code)?
Good catch, done.
https://codereview.chromium.org/188783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
