Thank you for review, Michael. I will land after re-running all tests.
My branch was already rebased, so the diff between patch sets includes other
stuff.
Here is how I addressed your comments:
https://codereview.chromium.org/188783003/diff/200001/src/objects-visiting.h
File src/objects-visiting.h (right):
https://codereview.chromium.org/188783003/diff/200001/src/objects-visiting.h#newcode490
src/objects-visiting.h:490: Object* VisitWeakList(Heap* heap,
On 2014/04/11 09:01:56, Michael Starzinger wrote:
suggestion: As discussed offline, I know you only moved this function
and didn't
change it, but a few lines of comments describing it here would be
nice. :)
Added this comment:
A weak list is single linked list where each element has a weak pointer
to the next element. Given the head of the list, this function removes
dead elements from the list and if requested records slots for
next-element pointers. The template parameter T is a WeakListVisitor
that defines how to access the next-element pointers.
https://codereview.chromium.org/188783003/diff/200001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/188783003/diff/200001/src/objects.h#newcode5317
src/objects.h:5317: inline bool can_be_weak_stub() {
On 2014/04/11 09:01:56, Michael Starzinger wrote:
nit: This is not really a primitive predicate, grouping it with the
other ones
seems counter-intuitive. Can we call it "CanBeWeakStub" instead and
separate if
from the predicates by an empty newline?
Done.
https://codereview.chromium.org/188783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
