+ulan
Seems reasonable to me, but adding Ulan to check as well.
https://codereview.chromium.org/223623003/diff/1/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://codereview.chromium.org/223623003/diff/1/src/arm/disasm-arm.cc#newcode1275
src/arm/disasm-arm.cc:1275: int fraction_bits = 32 - (instr->Bit(5) |
(instr->Bits(3, 0) << 1));
nit - please rewrite as:
(instr->Bits(3, 0) << 1) | (instr->Bit(5)
for clarity.
https://codereview.chromium.org/223623003/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/223623003/diff/1/src/arm/simulator-arm.cc#newcode2939
src/arm/simulator-arm.cc:2939: int fraction_bits = 32 - (instr->Bit(5) |
(instr->Bits(3, 0) << 1));
ditto
https://codereview.chromium.org/223623003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
