https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc#newcode696
src/isolate.cc:696: AccessCheckInfo* GetAccessCheckInfo(Isolate*
isolate,
static inline?
https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc#newcode722
src/isolate.cc:722: data = handle(GetAccessCheckInfo(this,
receiver)->data(), this);
I think you intended to use |access_check_info| here instead of
GetAccessCheckInfo(...).
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc#newcode5595
src/objects.cc:5595: RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate,
Object);
While we are here: after majority of calls to ReportFailedAccessCheck()
we check for scheduled exception but...
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc#newcode6372
src/objects.cc:6372: isolate->ReportFailedAccessCheck(object,
v8::ACCESS_SET);
... but here and in some other places we don't. And we don't even check
for scheduled exceptions after some calls to DefineAccessor(). Is it
worth adding the exception check to ReportFailedAccessCheck()?
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc#newcode13290
src/objects.cc:13290: isolate->ReportFailedAccessCheck(object,
v8::ACCESS_HAS);
Same note here and below.
https://codereview.chromium.org/234913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
