https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc#newcode696
src/isolate.cc:696: AccessCheckInfo* GetAccessCheckInfo(Isolate*
isolate,
On 2014/04/11 17:10:55, Igor Sheludko wrote:
static inline?
Done.
https://codereview.chromium.org/234913003/diff/10001/src/isolate.cc#newcode722
src/isolate.cc:722: data = handle(GetAccessCheckInfo(this,
receiver)->data(), this);
On 2014/04/11 17:10:55, Igor Sheludko wrote:
I think you intended to use |access_check_info| here instead of
GetAccessCheckInfo(...).
Done. Thanks for catching this.
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/234913003/diff/10001/src/objects.cc#newcode6372
src/objects.cc:6372: isolate->ReportFailedAccessCheck(object,
v8::ACCESS_SET);
On 2014/04/11 17:10:55, Igor Sheludko wrote:
... but here and in some other places we don't. And we don't even
check for
scheduled exceptions after some calls to DefineAccessor(). Is it worth
adding
the exception check to ReportFailedAccessCheck()?
I know about this, but I have no idea whether this will cause actual
problems, and prefer to investigate this later on. I opened an issue for
this and added TODOs.
https://codereview.chromium.org/234913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
