I only had a quick look so far, but I have already one suggestion: Instead
of
describing verbosely why passing a Handle<ExternalFooBarString> is safe,
just
pass a pointer to the raw data. This makes it obvious that the contract
holds
without reading any kind of (potentially lying ;-) comments. Moving a single
call to all call sites is a very good trade-off in our case.
https://codereview.chromium.org/214883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
