LGTM with one comment. In general I am not a big fan of "transferring
ownership"
of C-allocated memory, that almost always goes wrong (like in this case I
have
the feeling). Would it be possible to embed the external string stream into
the
parsing job somehow?
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc
File src/parser-thread.cc (right):
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc#newcode167
src/parser-thread.cc:167: delete current_task_;
This deletes the background parsing task, but I cannot find the place
where the external string stream is deleted. Is it missing?
https://codereview.chromium.org/214883002/diff/690001/src/preparse-data.h
File src/preparse-data.h (right):
https://codereview.chromium.org/214883002/diff/690001/src/preparse-data.h#newcode34
src/preparse-data.h:34: #include "preparse-data-format.h"
nit: Is it possible to alpha-sort includes here?
https://codereview.chromium.org/214883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
