lgtm with a nit:
https://codereview.chromium.org/239203002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/239203002/diff/1/src/objects.cc#newcode6950
src/objects.cc:6950: Handle<Name> name,
While we are here: since name can be null handle please use
MaybeHandle<> here...
https://codereview.chromium.org/239203002/diff/1/src/objects.cc#newcode6959
src/objects.cc:6959: map, name, result, simple_flag);
... and name.ToHandleChecked() here as CopyInsert() expects non-null
handle.
https://codereview.chromium.org/239203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
