Okay, this appears to make TSAN happy(ier), doesn't hurt performance, and
constrains the serializer to make a choice about enabling or disabling at
process start up, which is simpler.
https://codereview.chromium.org/240193002/diff/20001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/240193002/diff/20001/src/arm/assembler-arm.cc#newcode1082
src/arm/assembler-arm.cc:1082: #ifdef DEBUG
On 2014/04/16 09:18:46, Sven Panne wrote:
Why do we wrap this into #ifdef DEBUG here plus some other places, but
not in
ohters? I propose to move any #ifdef logic (if really necessary) into
TrySetPermanentlyDisabled, avoiding the need to repeat this horror at
all call
sites (something which we should do in general).
Thx Sven you got me wondering why we have this call at all. We actually
decide the Enabled/Disabled state at process startup, and we don't
toggle it. So this is superfluous code, removed.
https://codereview.chromium.org/240193002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
