Hi Hannes, hi Sven,
Hannes, I address your suggested changes, and Sven, here are the rather
tricky
changes required to let ARM generate code in order to probe features for
purposes of printing flags.
Thanks,
--Michael
https://codereview.chromium.org/240193002/diff/50001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/240193002/diff/50001/src/serialize.cc#newcode652
src/serialize.cc:652: Atomic32 Serializer::serialization_state_ =
SERIALIZER_STATE_UNINITIALIZED;
On 2014/04/17 09:48:10, Hannes Payer wrote:
AtomicWord
Done.
https://codereview.chromium.org/240193002/diff/50001/src/serialize.cc#newcode777
src/serialize.cc:777: NoBarrier_Store(&serialization_state_, state);
On 2014/04/17 09:48:10, Hannes Payer wrote:
Can we have a comment here why this works and why no barrier
loads/stores are
fine.
Can there by a enable/disable race?
Yes, done, and no.
https://codereview.chromium.org/240193002/diff/50001/src/serialize.cc#newcode791
src/serialize.cc:791: NoBarrier_Store(&serialization_state_,
SERIALIZER_STATE_UNINITIALIZED);
On 2014/04/17 09:48:10, Hannes Payer wrote:
The assumption is that this method is just invoked by one thread,
right?
Otherwise it wouldn't work. Please add a comment to explain the global
picture.
Good point, done.
https://codereview.chromium.org/240193002/diff/50001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/240193002/diff/50001/src/serialize.h#newcode587
src/serialize.h:587: static Atomic32 serialization_state_;
On 2014/04/17 09:48:10, Hannes Payer wrote:
I would prefer AtomicWord
Done.
https://codereview.chromium.org/240193002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
