LGTM with one nit.
https://codereview.chromium.org/239243018/diff/1/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/239243018/diff/1/src/factory.h#newcode127
src/factory.h:127: const char (&str)[N],
Wow. I did not know you could use array size as implicit template
argument. Nice.
https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):
https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc#newcode111
src/jsregexp.cc:111: isolate->Throw(*regexp_err);
We could use the handle version:
return isolate->Throw<Object>(regexp_err);
https://codereview.chromium.org/239243018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
