Addressed comment + some cleanup.
https://codereview.chromium.org/239243018/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/239243018/diff/1/src/d8.cc#newcode985
src/d8.cc:985:
factory->NewStringFromUtf8(i::CStrVector(js_args[j])).ToHandleChecked();
Not sure about this place, can it fail here?
https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):
https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc#newcode111
src/jsregexp.cc:111: isolate->Throw(*regexp_err);
On 2014/04/17 12:28:46, Yang wrote:
We could use the handle version:
return isolate->Throw<Object>(regexp_err);
Done.
https://codereview.chromium.org/239243018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
