https://codereview.chromium.org/251493004/diff/1/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-escape-analysis.cc#newcode202
src/hydrogen-escape-analysis.cc:202: if (representation.IsSmi()) {
Can we factor this out into a NewLoadReplacement helper (similar to the
NewMapCheckAndInsert) to preserve readability of the giant
AnalyzeDataFlow method?
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-escape-analysis.cc#newcode212
src/hydrogen-escape-analysis.cc:212: load_value->id(),
load_value->Mnemonic());
nit: The logging should print the actual replacement IMHO.
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-instructions.h#oldcode1731
src/hydrogen-instructions.h:1731: private:
Let's keep this constructor private and use HForceRepresentation::New
instead, that gives us implicit constant folding.
https://codereview.chromium.org/251493004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
