LGTM.
https://codereview.chromium.org/251493004/diff/20001/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/251493004/diff/20001/src/hydrogen-escape-analysis.cc#newcode177
src/hydrogen-escape-analysis.cc:177:
load->DeleteAndReplaceWith(replacement);
nit: I was actually thinking along the lines of having the
DeleteAndReplaceWith plus the printing outside. And the helper would
really just be a "NewLoadReplacement" that returns some other node as a
replacement. Thereby mutation of the existing graph is in the data-flow
analysis code.
https://codereview.chromium.org/251493004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
