On 2014/04/29 09:24:17, m.m.capewell wrote:
On 2014/04/29 06:26:54, Sven Panne wrote:
> On 2014/04/28 16:27:50, m.m.capewell wrote:
> > On 2014/04/28 08:18:53, Sven Panne wrote:
> > > Committed patchset #1 manually as r21001 (presubmit successful).
> >
> > I think this breaks ARM64 non-simulator builds, as at least
> > test/cctest/test-assembler-arm64.cc uses CPU::Setup().
>
> Hmmm, I am totally unable to test this, so it would be nice if you could
check:
>
> * Can we simply remove that line?
>
> * If not: What exactly goes wrong? Does replacing it with
> 'CpuFeatures::Probe(false)' work?
>
> Until we have bot coverage and/or less #if/#else/#fi horror, breaking
things
> will continue, I fear...
CpuFeatures::Probe(false) should be equivalent, if the function is visible
from
that file. We'll submit a patch, as we can test it.
Looks like Ulan has a fix already.
https://codereview.chromium.org/258993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
