https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (left):
https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc#oldcode137
src/arm/assembler-arm.cc:137: PrintFeatures();
On 2014/04/29 15:25:17, vincent.belliard.arm wrote:
Why did you removed this display?
It was very useful to check during the build that the snapshot was
generated
with the good options.
It is not done for other platforms, it is printed with --help, anyway
(twice before), and I don't think the current approach of #ifdef'ing
code just for ARM (where the other PrintFeatures is residing) directly
below src/ is a good idea, this has to go away, too. ARM-specififc stuff
should be below src/arm, the current approach is a hack.
https://codereview.chromium.org/258993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
