LGTM with comment.
https://codereview.chromium.org/264593002/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/264593002/diff/1/Makefile#newcode172
Makefile:172: # armneon=on/off. Deprecated, use armfpu=
I'd rather remove it completely...
https://codereview.chromium.org/264593002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/264593002/diff/1/build/toolchain.gypi#newcode156
build/toolchain.gypi:156: [ 'arm_fpu=="neon" or arm_neon==1', {
...and also remove it from the gypi file.
https://codereview.chromium.org/264593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
