Reviewers: mvstanton,
Message:
Hey Michael,
Here's the fix for the debug crash introduced with my last CL. As discussed
offline, it just moves the logic from code selection to code generation,
where
it's always safe to check map deprecation status.
PTAL
-- Benedikt
Description:
Fix crash in debug builds introduced with r21110.
Basically we should not check for map deprecation during
code selection, because that may run on the concurrent
compiler thread. So the fix is to move this logic to the
code generation phase instead, which is always run on the
main thread.
Please review this at https://codereview.chromium.org/263803005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+38, -129 lines):
M src/arm/lithium-arm.h
M src/arm/lithium-arm.cc
M src/arm/lithium-codegen-arm.h
M src/arm/lithium-codegen-arm.cc
M src/arm64/lithium-arm64.h
M src/arm64/lithium-arm64.cc
M src/arm64/lithium-codegen-arm64.h
M src/arm64/lithium-codegen-arm64.cc
M src/compiler.h
M src/ia32/lithium-codegen-ia32.h
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/lithium-ia32.h
M src/ia32/lithium-ia32.cc
M src/lithium-codegen.h
M src/lithium-codegen.cc
M src/mips/lithium-codegen-mips.h
M src/mips/lithium-codegen-mips.cc
M src/mips/lithium-mips.h
M src/mips/lithium-mips.cc
M src/x64/lithium-codegen-x64.h
M src/x64/lithium-codegen-x64.cc
M src/x64/lithium-x64.h
M src/x64/lithium-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
