https://codereview.chromium.org/261953002/diff/100001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/261953002/diff/100001/src/arm/simulator-arm.cc#newcode637
src/arm/simulator-arm.cc:637: if (i_cache == NULL) return;
Huh? Does this really belong to this CL?
https://codereview.chromium.org/261953002/diff/100001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/261953002/diff/100001/src/arm64/macro-assembler-arm64.cc#newcode5100
src/arm64/macro-assembler-arm64.cc:5100: // TODO(mvstanton): this static
isn't thread safe.
Perhaps NoCodeAgeSequence should have a more generic name and be used
here, too?
https://codereview.chromium.org/261953002/diff/100001/src/codegen.h
File src/codegen.h (right):
https://codereview.chromium.org/261953002/diff/100001/src/codegen.h#newcode128
src/codegen.h:128: bool Match(byte* candidate) const {
"IsPrefixOf" describes the intent more closely.
https://codereview.chromium.org/261953002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
