Hi Sven, thanks for the comments, PTAL,
--Michael
https://codereview.chromium.org/261953002/diff/100001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/261953002/diff/100001/src/arm64/macro-assembler-arm64.cc#newcode5100
src/arm64/macro-assembler-arm64.cc:5100: // TODO(mvstanton): this static
isn't thread safe.
On 2014/05/05 07:54:14, Sven Panne wrote:
Perhaps NoCodeAgeSequence should have a more generic name and be used
here, too?
I changed it to CodeAgingHelper, and it can determine if your code is
old or young, this addressed the thread safety issue too.
https://codereview.chromium.org/261953002/diff/100001/src/codegen.h
File src/codegen.h (right):
https://codereview.chromium.org/261953002/diff/100001/src/codegen.h#newcode128
src/codegen.h:128: bool Match(byte* candidate) const {
On 2014/05/05 07:54:14, Sven Panne wrote:
"IsPrefixOf" describes the intent more closely.
I ended up generalizing the class, and the notion of "IsYoung()" and
"IsOld()" worked nicely.
https://codereview.chromium.org/261953002/diff/120001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/261953002/diff/120001/src/arm/simulator-arm.cc#newcode637
src/arm/simulator-arm.cc:637: if (i_cache == NULL) return;
The reason this condition was being hit at snapshot time, is that now we
create instructions on isolate initialization, rather than lazily when
we want to test code for young/old status. In the ARM simulator
environment, caching isn't set up until later in the initialization
process.
A better fix is that when the CodePatcher is initialized to create the
CodeAgingHelper::young_sequence_, we can ask that code flushing not be
used.
https://codereview.chromium.org/261953002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
