[v8-dev] Inlined IsFoundByRuntimeProbingOnly. (issue 265243004)

Mon, 05 May 2014 02:27:22 -0700 

Reviewers: Yang,

Description:
Inlined IsFoundByRuntimeProbingOnly.

It is only used internally at a single place.

Please review this at https://codereview.chromium.org/265243004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+10, -32 lines):
  M src/arm/assembler-arm.h
  M src/arm64/cpu-arm64.h
  M src/ia32/assembler-ia32.h
  M src/mips/assembler-mips.h
  M src/x64/assembler-x64.h


Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index 677a48748f4cfde2c08f2b678345541b6a787a99..1c6a7f04f86c62e025b25a6acddba4e32eb4abb0 100644 
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -70,15 +70,11 @@ class CpuFeatures : public AllStatic {
     return Check(f, supported_);
   }

-  static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
-    ASSERT(initialized_);
-    return Check(f, found_by_runtime_probing_only_);
-  }
-
   static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
     return Check(f, cross_compile_) ||
            (IsSupported(f) &&
- (!Serializer::enabled(isolate) | | !IsFoundByRuntimeProbingOnly(f))); 
+            !(Serializer::enabled(isolate) &&
+              Check(f, found_by_runtime_probing_only_)));
   }

   static unsigned cache_line_size() { return cache_line_size_; }
Index: src/arm64/cpu-arm64.h
diff --git a/src/arm64/cpu-arm64.h b/src/arm64/cpu-arm64.h
index 4f7b499791f6215a118d7d061c3675ff860170e2..0b7a7d7f1feab31931c1dd3207350c607b3a57f7 100644 
--- a/src/arm64/cpu-arm64.h
+++ b/src/arm64/cpu-arm64.h
@@ -28,15 +28,9 @@ class CpuFeatures : public AllStatic {
     return false;
   };

-  static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
-    ASSERT(initialized_);
-    // There are no optional features for ARM64.
-    return false;
-  }
-
+  // There are no optional features for ARM64.
   static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
-    return (IsSupported(f) &&
- (!Serializer::enabled(isolate) | | !IsFoundByRuntimeProbingOnly(f))); 
+    return IsSupported(f);
   }

   // I and D cache line size in bytes.
Index: src/ia32/assembler-ia32.h
diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h
index 0e21e07a236a498401cbdf62be0a295591522198..3033db936b32ed7540ad35cca7c40185c6ffa1c3 100644 
--- a/src/ia32/assembler-ia32.h
+++ b/src/ia32/assembler-ia32.h
@@ -543,15 +543,11 @@ class CpuFeatures : public AllStatic {
     return Check(f, supported_);
   }

-  static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
-    ASSERT(initialized_);
-    return Check(f, found_by_runtime_probing_only_);
-  }
-
   static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
     return Check(f, cross_compile_) ||
            (IsSupported(f) &&
- (!Serializer::enabled(isolate) | | !IsFoundByRuntimeProbingOnly(f))); 
+            !(Serializer::enabled(isolate) &&
+              Check(f, found_by_runtime_probing_only_)));
   }

   static bool VerifyCrossCompiling() {
Index: src/mips/assembler-mips.h
diff --git a/src/mips/assembler-mips.h b/src/mips/assembler-mips.h
index dfb2e1a6e0764e83130cd256defd93854f33e9cd..860097c8affb09ded14ee399be4af6c4d27a6d7c 100644 
--- a/src/mips/assembler-mips.h
+++ b/src/mips/assembler-mips.h
@@ -436,15 +436,11 @@ class CpuFeatures : public AllStatic {
     return Check(f, supported_);
   }

-  static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
-    ASSERT(initialized_);
-    return Check(f, found_by_runtime_probing_only_);
-  }
-
   static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
     return Check(f, cross_compile_) ||
            (IsSupported(f) &&
- (!Serializer::enabled(isolate) | | !IsFoundByRuntimeProbingOnly(f))); 
+            !(Serializer::enabled(isolate) &&
+              Check(f, found_by_runtime_probing_only_)));
   }

   static bool VerifyCrossCompiling() {
Index: src/x64/assembler-x64.h
diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h
index 1bbc995a03a63b0ddda5ec6aaee74f02c4623525..685d46c094aae9f01b905ed32757d65168ca99d5 100644 
--- a/src/x64/assembler-x64.h
+++ b/src/x64/assembler-x64.h
@@ -463,15 +463,11 @@ class CpuFeatures : public AllStatic {
     return Check(f, supported_);
   }

-  static bool IsFoundByRuntimeProbingOnly(CpuFeature f) {
-    ASSERT(initialized_);
-    return Check(f, found_by_runtime_probing_only_);
-  }
-
   static bool IsSafeForSnapshot(Isolate* isolate, CpuFeature f) {
     return Check(f, cross_compile_) ||
            (IsSupported(f) &&
- (!Serializer::enabled(isolate) | | !IsFoundByRuntimeProbingOnly(f))); 
+            !(Serializer::enabled(isolate) &&
+              Check(f, found_by_runtime_probing_only_)));
   }

   static bool VerifyCrossCompiling() {


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to