I like the idea. I think we can make the implementation less fragile.
If someone adds masm load/store to the gap resolver without checking for
pending
operation, this might result in a hard to find bug.
It would be nice to have some kind of bottleneck between the gap resolver
and
the masm. Maybe introduce an intermediate class that pretends to be a masm
to
gap resolver, but has additional higher level methods like Store,
StoreConstant,
Load, StackSlotMove, and correctly maintains the pending operation? WDYT?
https://codereview.chromium.org/268673003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
