lgtm
https://codereview.chromium.org/261203003/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/261203003/diff/1/BUILD.gn#newcode47
BUILD.gn:47: visibility = ":*" # Only targets in this file can depend
on this.
Below here you'll want to say:
defines = []
And then turn all of the assignments below into += so you can support
more than one flag.
https://codereview.chromium.org/261203003/diff/1/BUILD.gn#newcode49
BUILD.gn:49: if (v8_enable_disassembler == true) {
Delete the " = true" parts. It's an if statement like C++ so
if (foo) {
is sufficient.
https://codereview.chromium.org/261203003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
