> In debug, I added the pending_pc_ field. If any instruction is added an assertion will be raised. So you shouldn't have any problem to spot the bug if someone add an instruction without checking for pending operation. You're right.
> However, I like your idea of a masm like class which handles the pending. It may be reused. Do you want me to develop such a class? Yep, let's try that. I hope separating handling of the pending and the gap resolver will simplify the code. On Tue, May 6, 2014 at 10:43 AM, Vincent Belliard <[email protected]>wrote: > In debug, I added the pending_pc_ field. If any instruction is added an > assertion will be raised. So you shouldn't have any problem to spot the bug > if someone add an instruction without checking for pending operation. > > However, I like your idea of a masm like class which handles the pending. > It may be reused. Do you want me to develop such a class? > > > On Mon, May 5, 2014 at 9:53 AM, <[email protected]> wrote: > >> I like the idea. I think we can make the implementation less fragile. >> >> If someone adds masm load/store to the gap resolver without checking for >> pending >> operation, this might result in a hard to find bug. >> >> It would be nice to have some kind of bottleneck between the gap resolver >> and >> the masm. Maybe introduce an intermediate class that pretends to be a >> masm to >> gap resolver, but has additional higher level methods like Store, >> StoreConstant, >> Load, StackSlotMove, and correctly maintains the pending operation? WDYT? >> >> >> https://codereview.chromium.org/268673003/ >> > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
