https://codereview.chromium.org/268673003/diff/40001/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/268673003/diff/40001/src/arm64/assembler-arm64.cc#newcode298
src/arm64/assembler-arm64.cc:298: const MemOperand& operandA,
Nit: indent to four spaces
https://codereview.chromium.org/268673003/diff/40001/src/arm64/assembler-arm64.cc#newcode308
src/arm64/assembler-arm64.cc:308: ((operandA.offset() & 0x7) != 0)) {
Is the offset required to be multiple of 8 or multiple of "access_size"?
Shoudn't the condition also check operandB.offset() if it comes before
operandA?
https://codereview.chromium.org/268673003/diff/40001/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):
https://codereview.chromium.org/268673003/diff/40001/src/arm64/assembler-arm64.h#newcode713
src/arm64/assembler-arm64.h:713: kPairBA }; // Can use a pair
instruction (operandB has lower address).
Nit: "};" should be in a separate line.
https://codereview.chromium.org/268673003/diff/40001/src/arm64/delayed-masm-arm64.h
File src/arm64/delayed-masm-arm64.h (right):
https://codereview.chromium.org/268673003/diff/40001/src/arm64/delayed-masm-arm64.h#newcode45
src/arm64/delayed-masm-arm64.h:45: need_to_restore_root_ = true;
I think the root register and its management belong to GapResolver
because it is used both for breaking cycles and for storing constants.
GapResolver knows that it is correct because constant moves come after
breaking cycles, but there is no way to tell that by just looking at
this class. So having root register in this class introduces some
implicit dependency between GapResolver and this class.
Can we instead pass the scratch register to StoreConstant and flush it
in EmitPending/ResetPending ?
https://codereview.chromium.org/268673003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
