https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc#newcode15003
src/runtime.cc:15003: CONVERT_ARG_HANDLE_CHECKED(Object, callback, 1);
On 2014/05/05 19:55:05, adamk wrote:
On 2014/05/03 05:28:26, Toon Verwaest wrote:
> I think this should become JSReceiver to handle function proxy
callbacks.
I've filed a but to track the fact that proxies don't work with
Object.observe
at the moment: https://code.google.com/p/v8/issues/detail?id=3310
> On 2014/05/02 19:31:37, Jakob wrote:
> > Please be as specific as you can regarding the object type here. I
have a
> > feeling |callback| must be a JSFunction, so use
> > CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 1);
>
Thanks! While you're at it, can you please also create bugs to track the
issues that
1. observing the global object does not currently allowed, due to
various issues (esp with navigation, e.g. notifier context)
2. observing/unobserving in the middle of a splice event does not work
correctly
3. change records in cross context scenarios live in different contexts
depending on how they are created
4. the implementation of observe does not handle acceptList accurately
(e.g. observable side effects in accessing .length multiple times)
Some of these might require modifications/extensions to the spec as
well.
https://codereview.chromium.org/263833007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
