On 2014/05/06 19:10:19, adamk wrote:
On 2014/05/06 10:03:49, rossberg wrote:
> https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc
> File src/runtime.cc (right):
>
>
https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc#newcode15003
> src/runtime.cc:15003: CONVERT_ARG_HANDLE_CHECKED(Object, callback, 1);
> On 2014/05/05 19:55:05, adamk wrote:
> > On 2014/05/03 05:28:26, Toon Verwaest wrote:
> > > I think this should become JSReceiver to handle function proxy
callbacks.
> >
> > I've filed a but to track the fact that proxies don't work with
Object.observe
> > at the moment: https://code.google.com/p/v8/issues/detail?id=3310
> >
> > > On 2014/05/02 19:31:37, Jakob wrote:
> > > > Please be as specific as you can regarding the object type here. I
have
a
> > > > feeling |callback| must be a JSFunction, so use
> > > > CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 1);
> > >
> >
>
> Thanks! While you're at it, can you please also create bugs to track the
issues
> that
>
> 1. observing the global object does not currently allowed, due to
various
issues
> (esp with navigation, e.g. notifier context)
Not sure where to file this. It's sort of a spec bug, except it's outside
the
purview of ECMAScript. I don't think we want to allow this, so long as
we're
using Mozilla's split-global approach to cross-frame access at least.
> 2. observing/unobserving in the middle of a splice event does not work
correctly
https://code.google.com/p/v8/issues/detail?id=3314
> 3. change records in cross context scenarios live in different contexts
> depending on how they are created
https://code.google.com/p/v8/issues/detail?id=3316 (this one's a little
fuzzy
as
I back-formed it from the thread between Toon and Rafael, feel free to add
more
detail to the bug)
> 4. the implementation of observe does not handle acceptList accurately
(e.g.
> observable side effects in accessing .length multiple times)
https://code.google.com/p/v8/issues/detail?id=3315
> Some of these might require modifications/extensions to the spec as
well.
Thanks, sounds good.
https://codereview.chromium.org/263833007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
