https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py
File tools/generate-runtime-tests.py (right):
https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py#newcode257
tools/generate-runtime-tests.py:257: return "%s.js" % self.name.lower()
On 2014/04/25 12:54:34, Dmitry Lomov (chromium) wrote:
Suggestion: why lowercase names for tests? It's ok to have mixed-case
filenames,
and easier to map function name to test case.
I don't care much either way, but
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=File_Names#File_Names
states a clear preference.
https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py#newcode475
tools/generate-runtime-tests.py:475: print("Missing testcase for %s,
please run '%s generate'" %
On 2014/04/25 12:54:34, Dmitry Lomov (chromium) wrote:
Suggestion: would also be awesome to check if file is added to git.
Yeah, that's a possible follow-up change.
https://codereview.chromium.org/250923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
