LGTM! Nice work! The degree of hackiness in this script could be a bit
lower,
but I think for the scope of this script it's ok. If the scope gets widened
at
some point (e.g. to auto-generate more kinds of tests) then we should clean
up a
bit more first.
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py
File tools/generate-runtime-tests.py (right):
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode20
tools/generate-runtime-tests.py:20: BASEPATH = os.path.join(WORKSPACE,
"test", "mjsunit", "runtime-gen")
Wouldn't this fit better into the fuzz-natives test suite?
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode193
tools/generate-runtime-tests.py:193: self.ArgCtor = ctor
nit: lower case?
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode408
tools/generate-runtime-tests.py:408: if i > 0: call += ", "
how about collecting the names in a list and then defining call
afterwards as:
call = "%%%s%s(%s)" % (f.inline, f.name, ", ".join(arg_names))
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode450
tools/generate-runtime-tests.py:450: functions = FindRuntimeFunctions()
Would it be useful if it found also functions defined in extensions
(like free buffer)?
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode487
tools/generate-runtime-tests.py:487: files = os.listdir(BASEPATH)
Wonder if there appears a .svn folder on the bots here, once this is
committed?
https://codereview.chromium.org/250923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
