https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode6
src/hydrogen-check-elimination.cc:6:
Spurious change?
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode29
src/hydrogen-check-elimination.cc:29: CHECKED,
Please add comments about meaning of the states.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode363
src/hydrogen-check-elimination.cc:363: entry->state_ =
instr->maps_are_stable()
|| entry->check_->maps_are_stable()?
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode567
src/hydrogen-check-elimination.cc:567: entry->state_ =
HCheckTableEntry::UNCHECKED_STABLE;
Does it mean that we could end up adding multiple stability check
instructions
for the same set of maps?
We could probably fix that by setting CHECKED_STABLE state only for the
stability check instructions and instead of it initially use
UNCHECKED_STABLE
for all the other instructions with stable maps. WDYT?
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode737
src/hydrogen-check-elimination.cc:737: table->KillUnstableEntries();
I think you can return at this point as all the entries that are killed
below
must be unstable anyway.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode758
src/hydrogen-check-elimination.cc:758: bool osr_entries_ : 1;
Consider using GVNFlags instead of set of booleans.
https://codereview.chromium.org/266083007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
