https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode6
src/hydrogen-check-elimination.cc:6:
Updated to follow Google C++ Style Guide.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode29
src/hydrogen-check-elimination.cc:29: CHECKED,
On 2014/05/07 16:53:26, Igor Sheludko wrote:
Please add comments about meaning of the states.
Done.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode363
src/hydrogen-check-elimination.cc:363: entry->state_ =
instr->maps_are_stable()
entry->check_ may be NULL at this point. But entry->state_ is already
set according to the previous check, so it all comes down to setting
entry->state_ to CHECKED_STABLE if it was UNCHECKED_STABLE before, or
instr->maps_are_stable().
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode567
src/hydrogen-check-elimination.cc:567: entry->state_ =
HCheckTableEntry::UNCHECKED_STABLE;
This is not an issue, because the stability checks are simply markers
(i.e. they do not generate code, they do not add register constraints,
they do not change/depend on flags, etc.), but simply add their maps to
a set of maps in the LChunk.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode737
src/hydrogen-check-elimination.cc:737: table->KillUnstableEntries();
No, because we can have stored maps to objects with (UN)CHECKED_STABLE
entries, and this is handled below.
https://codereview.chromium.org/266083007/diff/20001/src/hydrogen-check-elimination.cc#newcode758
src/hydrogen-check-elimination.cc:758: bool osr_entries_ : 1;
On 2014/05/07 16:53:26, Igor Sheludko wrote:
Consider using GVNFlags instead of set of booleans.
Done.
https://codereview.chromium.org/266083007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
