https://codereview.chromium.org/159783002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/159783002/diff/1/src/objects.cc#newcode9910
src/objects.cc:9910: void JSFunction::Optimize(const char* reason) {
On 2014/02/18 09:24:48, titzer wrote:
Looks like you copied this right out of the compiler, TODOs and all.
Please put
it back.
This code was part of runtime-profiler. It should not be part of the
runtime-profiler since it operates on the JSFunction. Moved it to the
compiler. Done.
https://codereview.chromium.org/159783002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/159783002/diff/1/src/objects.h#newcode5476
src/objects.h:5476: void GetICCounts(int* ic_with_type_info_count,
On 2014/02/18 09:24:48, titzer wrote:
Nit: formatting
Done.
https://codereview.chromium.org/159783002/diff/1/src/objects.h#newcode7474
src/objects.h:7474: void Optimize(const char* reason);
On 2014/02/18 09:24:48, titzer wrote:
Please move this to the compiler. Yang did a big refactor to get rid
of the
previous compilation-related methods on JSFunction.
Done.
https://codereview.chromium.org/159783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
