https://codereview.chromium.org/159783002/diff/200001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/159783002/diff/200001/src/deoptimizer.cc#newcode326
src/deoptimizer.cc:326: if (code->marked_for_instant_optimization()) {
This isn't the right place for this somehow. It's surprising that
DeoptimizeMarkedCode actually calls the compiler.
https://codereview.chromium.org/159783002/diff/200001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/159783002/diff/200001/src/objects.cc#newcode12352
src/objects.cc:12352: if (instant_optimization)
code->set_marked_for_deoptimization(true);
You're setting the wrong thing here, I think. Why don't you collect the
functions you want to reoptimize here, and then do a loop over them to
compile them? Then you don't need extra machinery in the deoptimizer.
https://codereview.chromium.org/159783002/diff/200001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/159783002/diff/200001/src/objects.h#newcode5730
src/objects.h:5730: static const int
kMarkedForInstantOptimizationBitCount = 1;
This bit is just carrying stuff through the deoptimizer, to a place that
I don't think it belongs. I think you want to gather the list of
functions to reoptimize outside of the deoptimization infrastructure and
then process them there.
https://codereview.chromium.org/159783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
