LGTM with comments.
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/execution.py#newcode88
tools/testrunner/local/execution.py:88: # while the queue is filled.
Have you measured whether that would make a difference? Otherwise let's
drop the plan and the TODO.
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py
File tools/testrunner/local/pool.py (right):
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py#newcode52
tools/testrunner/local/pool.py:52: BUFFER = 100
As discussed, maybe make this worker_count * 4 or something like that?
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py#newcode55
tools/testrunner/local/pool.py:55: self.workers = workers
nit: without context, "workers" make me expect a list of worker objects.
I'd prefer "num_workers" or "worker_count" (or "jobs" which we use
elsewhere).
https://codereview.chromium.org/275093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
