Done. The total approach is ~0.5 seconds slower. I don't know why yet. The
time
could be won back by starting to test earlier (see below).
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/execution.py#newcode88
tools/testrunner/local/execution.py:88: # while the queue is filled.
It takes 0.5 seconds... I rather leave the todo and make a measurement
in a follow up CL if this can be improved. If not, I'll remove the todo.
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py
File tools/testrunner/local/pool.py (right):
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py#newcode52
tools/testrunner/local/pool.py:52: BUFFER = 100
On 2014/05/14 09:07:37, Jakob wrote:
As discussed, maybe make this worker_count * 4 or something like that?
Done.
https://codereview.chromium.org/275093002/diff/60001/tools/testrunner/local/pool.py#newcode55
tools/testrunner/local/pool.py:55: self.workers = workers
On 2014/05/14 09:07:37, Jakob wrote:
nit: without context, "workers" make me expect a list of worker
objects. I'd
prefer "num_workers" or "worker_count" (or "jobs" which we use
elsewhere).
Done.
https://codereview.chromium.org/275093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
