Looks good. I didn't understand one part with is_observed:
https://codereview.chromium.org/262053011/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/262053011/diff/80001/src/objects.cc#newcode4438
src/objects.cc:4438: } else if (is_observed) {
Shouldn't we check is_observed independent of (attributes !=
lookup.GetAttributes()) ?
https://codereview.chromium.org/262053011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
