Hi Ulan, thanks for the look. Comments addressed,
--Michael


https://codereview.chromium.org/262053011/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/262053011/diff/80001/src/objects.cc#newcode4438
src/objects.cc:4438: } else if (is_observed) {
On 2014/05/23 10:14:48, ulan wrote:
Shouldn't we check is_observed independent of (attributes !=
lookup.GetAttributes()) ?

Good catch. And I renamed the variable from dont_enqueue_records to
executed_set_prototype when is less awkward. Basically setting the
prototype is the one exception for this "observed" infrastructure.

https://codereview.chromium.org/262053011/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to