Done. Will focus on implementation now...
https://codereview.chromium.org/293023006/diff/40001/benchmarks/octane.json
File benchmarks/octane.json (right):
https://codereview.chromium.org/293023006/diff/40001/benchmarks/octane.json#newcode4
benchmarks/octane.json:4: "results_regexp": "^%s: (\\d+)$",
On 2014/05/22 15:27:02, m.m.capewell wrote:
DBC: on really slow platforms, Octane results can be reported with a
decimal
place, eg. 42.4.
Good point! The values transmitted to the dashboard are strings
anyway...
https://codereview.chromium.org/293023006/diff/40001/tools/run-benchmarks.py
File tools/run-benchmarks.py (right):
https://codereview.chromium.org/293023006/diff/40001/tools/run-benchmarks.py#newcode50
tools/run-benchmarks.py:50: "results_regexp": "^%s: (\\d+)$",
On 2014/05/23 10:02:35, ulan wrote:
Note that some benchmarks have custom result parsers (e.g.
V8GCHeapSizeKb).
I added the ability for custom results processors. Existing processors
might need a small rewrite as I won't allow a results parser to be also
the d8 runner.
https://codereview.chromium.org/293023006/diff/40001/tools/run-benchmarks.py#newcode78
tools/run-benchmarks.py:78: Path pieces are concatenated. D8 is always
run with the suite's path as cwd.
On 2014/05/23 10:02:35, ulan wrote:
Would be nice to the binary name (d8) as a parameter instead of
hardcoding it.
Done. Can be configured arbitrarily now with d8 as default.
https://codereview.chromium.org/293023006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
