Done.
https://codereview.chromium.org/293023006/diff/230004/benchmarks/octane.json
File benchmarks/octane.json (right):
https://codereview.chromium.org/293023006/diff/230004/benchmarks/octane.json#newcode1
benchmarks/octane.json:1: {
On 2014/05/28 11:16:27, Jakob wrote:
This file should be named "v8.json". The Octane suite is much bigger
and not
checked in here.
Done.
https://codereview.chromium.org/293023006/diff/230004/tools/run_benchmarks.py
File tools/run_benchmarks.py (right):
https://codereview.chromium.org/293023006/diff/230004/tools/run_benchmarks.py#newcode244
tools/run_benchmarks.py:244: # TODO(machenbach): This requires +.exe if
ran on windows.
On 2014/05/28 11:15:05, Jakob wrote:
nit: s/ran/run/
Done.
https://codereview.chromium.org/293023006/diff/230004/tools/run_benchmarks.py#newcode346
tools/run_benchmarks.py:346: if not options.mode.lower() in ["debug",
"release", "optdebug"]:
On 2014/05/28 11:15:05, Jakob wrote:
arguably running benchmarks in anything other than release mode
doesn't make
sense anyway
Done. Dropped the option completely.
https://codereview.chromium.org/293023006/diff/230004/tools/run_benchmarks.py#newcode387
tools/run_benchmarks.py:387: output =
commands.Execute(runnable.GetCommand(shell_dir), timeout=60)
On 2014/05/28 11:15:05, Jakob wrote:
for slow (mobile) devices 60 seconds might be too tight
Will make it configurable in a followup. Marked as TODO for now.
https://codereview.chromium.org/293023006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
