https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390
src/mips/builtins-mips.cc:390: __
DecodeField<Map::ConstructionCount>(a3, t0);
What do you think about storing decoded counter value in t8 in order to
avoid...
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode440
src/mips/builtins-mips.cc:440: Label no_inobject_slack_tracking;
On 2014/05/23 15:01:45, Paul Lind wrote:
The deleted LoadRoot for UndefinedValue needs to be added above this
if clause -
so its available on all possible paths to __
InitializeFieldsWithFiller(t5,
a0, t7)
There is one load at the top of the function. I think it is better to
move it here, before the if().
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode444
src/mips/builtins-mips.cc:444: __
DecodeField<Map::ConstructionCount>(t0);
... reloading here, like it was done for ia32?
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode453
src/mips/builtins-mips.cc:453: __ Addu(t6, t4, Operand(at)); // End of
object.
I think we can now move above two lines inside the if() block below.
https://codereview.chromium.org/294973013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
