Sorry for being late, but...
https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc#newcode401
src/mips/builtins-mips.cc:401: __ Pop(a1, a2);
t2 must be set to zero here (which is JSFunction::kNoSlackTracking)
since the slack tracking is actually over after the runtime call.
https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc#newcode440
src/mips/builtins-mips.cc:440:
I think t7 initialization should be moved here:
// Use t7 to hold undefined, which is used in several places below.
__ LoadRoot(t7, Heap::kUndefinedValueRootIndex);
Not sure if it survives after the runtime call above.
https://codereview.chromium.org/294973013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
