lgtm
Benedikt, since Sven is OOO, can you have a look as well?
https://codereview.chromium.org/293993021/diff/40001/src/natives-external.cc
File src/natives-external.cc (right):
https://codereview.chromium.org/293993021/diff/40001/src/natives-external.cc#newcode1
src/natives-external.cc:1: // Copyright 2011 the V8 project authors. All
rights reserved.
nit 2014
https://codereview.chromium.org/293993021/diff/40001/src/natives-external.cc#newcode97
src/natives-external.cc:97: };
nit. DISALLOW_COPY_AND_ASSIGN()
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-external.cc
File src/snapshot-external.cc (right):
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-external.cc#newcode17
src/snapshot-external.cc:17: class SnapshotImpl {
should be a struct (and use e.g. data_ instead of data)
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-external.cc#newcode39
src/snapshot-external.cc:39: static SnapshotImpl* impl_;
and this should be moved out of SnapshotImpl
https://codereview.chromium.org/293993021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
