LGTM with nits.
https://codereview.chromium.org/293993021/diff/40001/src/natives.h
File src/natives.h (right):
https://codereview.chromium.org/293993021/diff/40001/src/natives.h#newcode10
src/natives.h:10: namespace v8 { class StartupData; }
Nit: Add comment // Forward declarations.
https://codereview.chromium.org/293993021/diff/40001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/293993021/diff/40001/src/serialize.cc#newcode19
src/serialize.cc:19: #include "snapshot-source-sink.h"
Nit: serialize.h already includes snapshout-source-sink.h.
https://codereview.chromium.org/293993021/diff/40001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/293993021/diff/40001/src/serialize.h#newcode8
src/serialize.h:8: #include "v8.h"
Nit: Please don't introduce new v8.h includes, but instead, try to
include what you actually need.
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-common.cc
File src/snapshot-common.cc (right):
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-common.cc#newcode55
src/snapshot-common.cc:55: bool Snapshot::IsEnabled() {
Nit: IsEnabled() should be marked as const.
Why do we need that function at all? Looks like it does the same as
HaveASnapshotToStartFrom()?
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-external.cc
File src/snapshot-external.cc (right):
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-external.cc#newcode7
src/snapshot-external.cc:7: #include "v8.h"
Nit: No new v8.h includes if possible.
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):
https://codereview.chromium.org/293993021/diff/40001/src/snapshot-source-sink.h#newcode20
src/snapshot-source-sink.h:20: class SnapshotByteSource {
Nit: Mark as V8_FINAL.
https://codereview.chromium.org/293993021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
