LGTM with comments:
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py#newcode68
tools/testrunner/local/execution.py:68: t.duration =
self.perfdata.FetchPerfData(t) or 1.0
If perf data is conditionally not used, maybe it should also not be
harvested?
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py#newcode98
tools/testrunner/local/execution.py:98: self.tests = sorted(self.tests,
key=lambda t: t.duration, reverse=True)
Not totally happy with replacing generators with copied lists. We might
loose a few micro seconds :P
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py#newcode136
tools/testrunner/local/execution.py:136:
self.perfdata.UpdatePerfData(test)
Also here...
https://codereview.chromium.org/307553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
