https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py#newcode68
tools/testrunner/local/execution.py:68: t.duration =
self.perfdata.FetchPerfData(t) or 1.0
On 2014/05/28 11:08:32, Michael Achenbach wrote:
If perf data is conditionally not used, maybe it should also not be
harvested?
IMHO we should still harvest perf-data (assuming by harvest you mean
"measure and store it into the DB") because of the following reasons:
(1) When the test-harness is used without the flag from time to time,
then the data will already by populated from previous runs and (2)
should we ever decide to use the perf-data for something else besides
sorting, then the pure data won't hinge on the sorting flag.
https://codereview.chromium.org/307553003/diff/20001/tools/testrunner/local/execution.py#newcode98
tools/testrunner/local/execution.py:98: self.tests = sorted(self.tests,
key=lambda t: t.duration, reverse=True)
On 2014/05/28 11:12:16, Jakob wrote:
On 2014/05/28 11:08:32, Michael Achenbach wrote:
> Not totally happy with replacing generators with copied lists. We
might loose
a
> few micro seconds :P
Right, should probably use self.tests.sort(key=...) instead. My bad.
Will upload a follow-up CL to address this.
https://codereview.chromium.org/307553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
