On 2014/06/10 09:00:12, vincent.belliard.arm wrote:

https://codereview.chromium.org/268673003/diff/60001/src/arm64/delayed-masm-arm64.h
File src/arm64/delayed-masm-arm64.h (right):


https://codereview.chromium.org/268673003/diff/60001/src/arm64/delayed-masm-arm64.h#newcode55
src/arm64/delayed-masm-arm64.h:55: scratch_register_acquired_ = true;
This function is only used in debug to ensure that we don't use the scratch
register for a constant while the register is acquired.
If the scratch register is really used after acquired, the saved value will be
reset (or set to an other value).

I meant instead of checking for scratch register after each Ldr, Ldp, Mov,
wouldn't it be cleaner to reset the value to zero here once?

https://codereview.chromium.org/268673003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to